PXP-8363 Fix/samesite cookie #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 11478
💛 - Coveralls |
mfshao
commented
Aug 6, 2021
mfshao
commented
Aug 6, 2021
| @@ -46,7 +46,8 @@ retry = "^0.9.2" | |||
| sqlalchemy = "^1.3.3" | |||
| storageclient = {git = "https://github.com/uc-cdis/storage-client", rev = "1.0.2"} | |||
| userdatamodel = "^2.3.3" | |||
| werkzeug = "^0.16.0" | |||
| werkzeug = "^1.0.0" | |||
There was a problem hiding this comment.
need to bump up this so we can add samesite in tests
mfshao
commented
Aug 6, 2021
| @@ -46,7 +46,8 @@ retry = "^0.9.2" | |||
| sqlalchemy = "^1.3.3" | |||
| storageclient = {git = "https://github.com/uc-cdis/storage-client", rev = "1.0.2"} | |||
| userdatamodel = "^2.3.3" | |||
| werkzeug = "^0.16.0" | |||
| werkzeug = "^1.0.0" | |||
| cachelib = "^0.2.0" | |||
There was a problem hiding this comment.
need to add this because the werkzeug bump
paulineribeyre
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-8363
Add
samesite="Lax"to cookies ofaccess_tokenandfenceThis shouldn't breaks anything since some browsers (Chrome/Edge) has already been using
Laxas default value of
samesiteif not declaredTo fix vulnerability documented in Veracode scan report (link in Jira ticket)
Improvements
samesite="Lax"to cookies ofaccess_tokenandfence