Remove fallback to sub in RAS #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 11847
💛 - Coveralls |
Avantol13
reviewed
Oct 12, 2021
| @@ -179,15 +179,6 @@ def get_user_id(self, code): | |||
| if userinfo.get("UserID"): | |||
| username = userinfo["UserID"] | |||
| field_name = "UserID" | |||
| elif userinfo.get("userid"): | |||
There was a problem hiding this comment.
I actually see userid in almost all logs from RAS. We probably still want to support either case, but just not fallback on other fields
Avantol13
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RAS sometimes not sending the correct userinfo response causes access issues downstream. We should error out instead of falling back to avoid issues on the client-side since some depend on the UserID response to be consistent.
Improvements