Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hatchery pay model improvements #70

Merged
merged 25 commits into from
Aug 8, 2023
Merged

Hatchery pay model improvements #70

merged 25 commits into from
Aug 8, 2023

Conversation

nss10
Copy link
Contributor

@nss10 nss10 commented Aug 6, 2023

Jira Ticket: BRH-602, BRH-621

New Features

  • Added /resetpaymodels endpoint
  • Pay models are automatically reset when a workspace session is terminated.

Breaking Changes

  • /launch endpoint throws an error when there is no pay model selected (For commons with paymodels)
  • /setPaymodel throws an error when there is no active workspace running. (For commons with paymodels)

Bug Fixes

  • /launch endpoint throws a 400 BAD Request when a request without username is sent.

Improvements

  • Added unit tests for all the updated functions
  • Some error messages and response codes are updated to be more specific

Related document - BRH-512

@nss10 nss10 changed the title Feat/add reset paymodels Hatchery pay model improvements Aug 6, 2023
@nss10 nss10 requested a review from tianj7 August 6, 2023 00:24
paulineribeyre pushed a commit that referenced this pull request Oct 10, 2023
* add reset paymodel and code refactoring
* Updating `resetPayModel` only after the workspace is terminated compleletely
* Add `hatchery.go` tests
paulineribeyre pushed a commit that referenced this pull request Oct 10, 2023
* add reset paymodel and code refactoring
* Updating `resetPayModel` only after the workspace is terminated compleletely
* Add `hatchery.go` tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants