test(leftovers): add tests to hit uncovered code #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
paulineribeyre
requested changes
Aug 12, 2019
There was a problem hiding this comment.
/indexd/index/drivers/query/__init__.py is covered at 75% because of 2 abstract methods that use pass instead of raise NotImplementedError("TODO") like our other abstract methods do. NotImplementedError is ignored by the coverage report, so if we change these functions to use it the coverage for this file will be 100%
paulineribeyre
force-pushed
the
test/improve-coverage
branch
from
6278c2e
to
59324ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds miscellaneous tests to cover leftover uncovered code.
Improvements
Adds missing unit tests