tests(misc): add unit tests #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
There was a problem hiding this comment.
good idea testing these, but what do you think about creating a single test test_index_list_invalid_param: where you test all of these:
"limit must be an integer", "limit must be between 0 and 1024", "size must be an integer" and "size must be > 0"
Also i think these are duplicates so we should remove one. i think the actual min limit is 0 https://github.com/uc-cdis/indexd/blob/2.0.1/indexd/index/blueprint.py#L67 https://github.com/uc-cdis/indexd/blob/2.0.1/indexd/index/blueprint.py#L112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to improve test coverage.
Improvements