Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PPS-261): (feat) Add service-info endpoint to DRS #356

Merged
merged 12 commits into from
Apr 15, 2023

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Apr 10, 2023

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

indexd/utils.py Outdated Show resolved Hide resolved
indexd/drs/blueprint.py Outdated Show resolved Hide resolved
indexd/drs/blueprint.py Outdated Show resolved Hide resolved
indexd/drs/blueprint.py Outdated Show resolved Hide resolved
indexd/drs/blueprint.py Outdated Show resolved Hide resolved
indexd/default_settings.py Outdated Show resolved Hide resolved
"artifact": "drs",
"version": "1.0.0",
},
"version": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump this up to 1.0.3

ret = {
"id": drs_dist.get("id", reverse_domain_name),
"name": drs_dist.get("name", "DRS System"),
"version": drs_dist.get("version", "1.0.0"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same can we bump the version here

indexd/drs/blueprint.py Outdated Show resolved Hide resolved
indexd/default_settings.py Show resolved Hide resolved
indexd/default_settings.py Outdated Show resolved Hide resolved
indexd/utils.py Show resolved Hide resolved
tests/default_test_settings.py Outdated Show resolved Hide resolved
tests/test_drs.py Outdated Show resolved Hide resolved
Copy link
Member

@MichaelLukowski MichaelLukowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants