-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PPS-261): (feat) Add service-info endpoint to DRS #356
Conversation
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
indexd/default_settings.py
Outdated
"artifact": "drs", | ||
"version": "1.0.0", | ||
}, | ||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bump this up to 1.0.3
indexd/drs/blueprint.py
Outdated
ret = { | ||
"id": drs_dist.get("id", reverse_domain_name), | ||
"name": drs_dist.get("name", "DRS System"), | ||
"version": drs_dist.get("version", "1.0.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same can we bump the version here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://ga4gh.github.io/data-repository-service-schemas/preview/release/drs-1.3.0/docs/#tag/Service-Info
New Features
/service-info
endpoint