-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(configs): remove configs from source control #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhaley
requested review from
craigrbarnes,
mfshao,
haraprasadj,
ZakirG and
johnfrancismccann
August 11, 2021 22:52
williamhaley
force-pushed
the
chore/configs
branch
from
August 11, 2021 22:59
775bfab
to
5ea6d6e
Compare
mfshao
approved these changes
Aug 11, 2021
haraprasadj
approved these changes
Aug 16, 2021
williamhaley
force-pushed
the
chore/configs
branch
2 times, most recently
from
August 24, 2021 15:02
14f6eb3
to
47a3b72
Compare
This was referenced Oct 6, 2021
This was referenced Oct 19, 2021
This was referenced Oct 29, 2021
This was referenced Nov 30, 2021
Closed
This was referenced Dec 10, 2021
This was referenced Jan 10, 2022
Closed
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This was referenced Feb 3, 2022
This was referenced Feb 16, 2022
This was referenced Feb 23, 2022
Merged
This was referenced Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to uc-cdis/cdis-manifest#3332
Jira Ticket: HP-291, HP-320
Improvements
Deployment changes
metadata/aggregate_config.json
file should be created as part of the manifest config for a commons and the appropriate environment vars formetadata
should be defined in the manifest JSONkubectl exec $(gen3 pod metadata) -- python /src/src/mds/populate.py --config /aggregate_config.json --hostname esproxy-service --port 9200