Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix es type #276

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Fix es type #276

merged 4 commits into from
Jul 2, 2024

Conversation

thanh-nguyen-dang
Copy link
Contributor

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/MIDRC-655
Fix boolean type in nested properties

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

Copy link

github-actions bot commented Jul 2, 2024

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

Copy link

github-actions bot commented Jul 2, 2024

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_etl.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

Copy link

@tlicht3 tlicht3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone else should also approve this ,but it looks good to me :)

Copy link

@jacob50231 jacob50231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thanh-nguyen-dang thanh-nguyen-dang merged commit a692665 into master Jul 2, 2024
9 checks passed
@thanh-nguyen-dang thanh-nguyen-dang deleted the fix/es_type branch July 2, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants