-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DidParser/BytesToKey API should enable use of other DID methods #3
Comments
Hi @chunningham thank you for your consideration and the kind appraisal! As you probably have noted, this crate is still "alpha." The API should be considered incomplete, in-progress and probably volatile. The UCAN-spec requires A PR would be welcome, although given the alpha nature of this crate I would ask for your flexibility during the review process. One important consideration to keep in mind: I am explicitly developing a plausible web browser deployment path via the WASM target. This doesn't demand that all features be supported on the web, but it does mean that we should strive to maintain parity across targets and also keep the library size lean (as feasibility / practicality allows). |
Just to fill in the inference gap, the key difference (pun intended) is that in The most general complication is that more complicated methods generally require a resource fetch over a network as they treat the DID Document as a mutable resource, allowing the set of public keys for a given DID to be updated, necessitating |
Thank you for that swift (and probably sparse) survey of what we are considering here @chunningham . Here are my reactions (in no particular order):
|
feat: Implement Serialize/Deserialize for UCAN
Excellent crate! I understand the initial implementation approach of being bound to
did:key
, but the API ofBytesToKey
andDidParser::parse
assumes/requires that:Which actually permanently rules out any non-
did:key
methods (did:pkh
is generative but a pub key cannot be extracted from the DID, and most other DID methods are not generative/require resolution and so would needDidParser::parse
andBytesToKey
to beasync
). Is there interest in a PR to move to a more general API to support such methods?The text was updated successfully, but these errors were encountered: