Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SAIF & Waveforms for Post-P&R Power #1108

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Fix SAIF & Waveforms for Post-P&R Power #1108

merged 1 commit into from
Feb 4, 2022

Conversation

harrisonliew
Copy link
Contributor

Related issue:

Type of change: bug fix

Impact: other

Release Notes

  • TestDriver is now the top-level module in testbenches, so the scope for SAIF dumping must include TestDriver
  • Post-P&R power analysis features are most useful with SAIFs and waveforms, so it should depend on the sim-par-debug target rather than just sim-par
  • SAIF passing from simulation to power is handled automatically by Hammer, no need to include in Makefile
  • Waveforms now passed to power target correctly

@harrisonliew harrisonliew merged commit ef9c5b4 into dev Feb 4, 2022
@harrisonliew harrisonliew deleted the saif_fix branch February 4, 2022 07:20
@abejgonzalez abejgonzalez mentioned this pull request Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

@colinschmidt colinschmidt Awaiting requested review from colinschmidt

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harrisonliew @jerryz123