Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Duplicate Compiler Flags #1367

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Remove Duplicate Compiler Flags #1367

merged 6 commits into from
Mar 2, 2023

Conversation

joonho3020
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@joonho3020 joonho3020 closed this Feb 23, 2023
@joonho3020 joonho3020 reopened this Feb 23, 2023
abejgonzalez
abejgonzalez requested changes Mar 2, 2023
View reviewed changes
common.mk Outdated
export mfc_extra_anno_contents
$(FINAL_ANNO_FILE) $(MFC_EXTRA_ANNO_FILE): $(ANNO_FILE)
export sfc_extra_low_transforms_anno_contents
$(EXTRA_ANNO_FILE) $(MFC_EXTRA_ANNO_FILE) $(SFC_EXTRA_ANNO_FILE): $(ANNO_FILE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a grouped target &: since you are generating multiple files from one

abejgonzalez
abejgonzalez reviewed Mar 2, 2023
View reviewed changes
common.mk Outdated Show resolved Hide resolved
abejgonzalez
abejgonzalez reviewed Mar 2, 2023
View reviewed changes
common.mk Outdated Show resolved Hide resolved
abejgonzalez
abejgonzalez approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez mentioned this pull request Mar 2, 2023
Closed
16 tasks
@abejgonzalez abejgonzalez merged commit c0b2708 into main Mar 2, 2023
@joonho3020 joonho3020 deleted the rm-duplicate-compiler-anno branch March 2, 2023 07:44
@tymcauley tymcauley mentioned this pull request Mar 2, 2023
Closed
3 tasks
sriramsridhar23 pushed a commit that referenced this pull request Mar 15, 2023
@joonho3020 @abejgonzalez
Remove Duplicate Compiler Flags (#1367)
d8b2992 
* Remove Duplicate Compiler Flags

* Cleanup & fixes for MultipleMMIO

* bump barstools

* Update common.mk

* Update common.mk

---------

Co-authored-by: Abraham Gonzalez <abe.j.gonza@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joonho3020 @abejgonzalez