Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump barstools to use Scala 2.13 #1371

Closed
wants to merge 1 commit into from

Conversation

tymcauley
Copy link
Contributor

Related PRs / Issues:

Merges ucb-bar/barstools#127 and resolves #1364.

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@tymcauley
Copy link
Contributor Author

@jerryz123 any action I need to take to resolve this failure? https://github.com/ucb-bar/chipyard/actions/runs/4301027445/jobs/7511505150

Not sure if that's just a spurious problem, and the job needs to be restarted.

@tymcauley
Copy link
Contributor Author

Huh, well now that same job has failed twice: https://github.com/ucb-bar/chipyard/actions/runs/4308888281/jobs/7515872594

Any clues as to why? Does the CI job need to by run by mergify or something?

@abejgonzalez
Copy link
Contributor

Actually, #1367 added your changes in with another fix. Let's merge that PR in to get your changes.

@tymcauley
Copy link
Contributor Author

Sounds good!

@tymcauley tymcauley deleted the bump-barstools-scala-2.13 branch March 2, 2023 00:06
@abejgonzalez
Copy link
Contributor

As for the CI issue, if PR'ing from a fork you don't have permissions to run CI. So you have to run mergify rebase/copy to create a new PR that is local to the repo to get permissions and run the CI (only devs on the repo can use mergify)

@tymcauley
Copy link
Contributor Author

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Barstools still uses Scala 2.12
2 participants