Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] just to check - conflict detection #109

Open
wants to merge 135 commits into
base: master
Choose a base branch
from
Open

[WIP] just to check - conflict detection #109

wants to merge 135 commits into from

Commits on Jan 9, 2021

  1. Configuration menu
    Copy the full SHA
    cae5bd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Attempt to fix

    hngenc committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    48c2046 View commit details
    Browse the repository at this point in the history
  2. Fix about_to_fire_all_rows

    hngenc committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    b9a22d5 View commit details
    Browse the repository at this point in the history
  3. Make SRAMs single-ported

    hngenc committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    3dfca8b View commit details
    Browse the repository at this point in the history
  4. Simplify the scratchpad

    hngenc committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    94a53f0 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #43 from ucb-bar/singleported

    Default to using single-ported scratchpad memories
    hngenc committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    f44473d View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Fix max block len computation (#53)

    * Fix max_block_len computation
    
    * Reduce CI_MAKE_NPROC
    
    * Support large block mvins in loopmatmul for transposed matrices
    jerryz123 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    61edc05 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2021

  1. Configuration menu
    Copy the full SHA
    9dc6ec8 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Remove popcounts in dma (#55)

    hngenc committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    c7a2100 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8335f1b View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Chip config (#58)

    SeahK committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    6d183b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b4d235 View commit details
    Browse the repository at this point in the history
  3. Update ChipConfig

    jerryz123 committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    bed471f View commit details
    Browse the repository at this point in the history
  4. Merge pull request #59 from ucb-bar/chipconfig-update

    Update ChipConfig
    jerryz123 committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    e75b5e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Add pipeline register after LoopMatmul units (#60)

    * Add pipeline register between LoopMatmul and ROB
    
    * Use a 2-entry queue instead
    
    * Monitor all pipeline registers for io.busy
    jerryz123 committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    2f645ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    21ec295 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07171fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4609996 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. Configuration menu
    Copy the full SHA
    279718a View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Configuration menu
    Copy the full SHA
    c9e9b1a View commit details
    Browse the repository at this point in the history
  2. Fix Firesim Freeze (#62)

    Fixed deadlock when a bias is loaded in at the same moment that a zero-write occurs. Expanded ports that were too small.
    hngenc committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3714ad5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    344c76c View commit details
    Browse the repository at this point in the history
  4. Add FP configs and fix them (#64)

    * Add FP configs and fix zero-writer connections, as well as Tiler dimensions
    
    * Bump gemmini-rocc-tests
    
    * Removed unusued DMAWriteCommandTracker
    
    * Implement gt for floats
    
    Tested with FP32 4-by-4 config
    hngenc committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    1a6ed24 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #66 from ucb-bar/vsm-scale

    Time-multiplex the VectorScalarMultiplier
    jerryz123 committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    66c1513 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e4ce774 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Configuration menu
    Copy the full SHA
    63e2bfe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf191ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96b59a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    353b9e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Configuration menu
    Copy the full SHA
    3ef8907 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff4825d View commit details
    Browse the repository at this point in the history
  3. debugging

    jerryz123 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    2d1c508 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Configuration menu
    Copy the full SHA
    adf41e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e1d512f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a356ec6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6c0e603 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    1f704d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Configuration menu
    Copy the full SHA
    9a92fa0 View commit details
    Browse the repository at this point in the history
  2. Bump Chipyard

    jerryz123 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    be80e39 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. Bump Spike

    jerryz123 committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    b29a14b View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Configuration menu
    Copy the full SHA
    98374db View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Configuration menu
    Copy the full SHA
    961f625 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    347c48b View commit details
    Browse the repository at this point in the history
  3. Merge pull request #72 from ucb-bar/loopmatmul-robsize

    Scale LoopMatmul with rob size
    jerryz123 committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    765e9ab View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Merge pull request #70 from ucb-bar/parameterize-opcode

    Parameterize opcode
    jerryz123 committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    7f77625 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    728801e View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Fix conv FSM freeze (#69)

    Made these changes to fix conv FSM:
    * Fix a_stride updates in ROB
    * Make the ROB's block_mvin raw checks less cautious
    * Stop GARBAGE_ADDRs from being considered as hazards in ROB
    * Fix a typo in `LoopConv/LdInput`
    
    Made these changes to improve performance:
    * Replaced downsampling layers with a series of strided matmuls
    * Improved conv tiling factor selection
    * Added block-mvout for resadds
    * Add config options for the ExecuteController to only read data from the spad, and only write data to the accumulator. This eliminates RAW-hazard checking delays in the ExecuteController.
    
    Performance:
    * ResNet50: 153709356 cycles (40% utilization)
    hngenc committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    a7b0d8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e832e2d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Address PR feedback

    jerryz123 committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    1c5fb09 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Configuration menu
    Copy the full SHA
    373bf99 View commit details
    Browse the repository at this point in the history
  2. change to loopconv

    SeahK committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    a62a404 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. save

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    efaf15c View commit details
    Browse the repository at this point in the history
  2. first trial with conv_fsm

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    c7613a8 View commit details
    Browse the repository at this point in the history
  3. first trial with conv_fsm

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    49786e9 View commit details
    Browse the repository at this point in the history
  4. fixed tag initialization

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    e67ecf5 View commit details
    Browse the repository at this point in the history
  5. printf

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    50147e9 View commit details
    Browse the repository at this point in the history
  6. ISA change

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    8879d2c View commit details
    Browse the repository at this point in the history
  7. config bugs

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    8e429ad View commit details
    Browse the repository at this point in the history
  8. debugging

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    a7d0b31 View commit details
    Browse the repository at this point in the history
  9. decreased wire width

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    908a9bc View commit details
    Browse the repository at this point in the history
  10. fixing bugs

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    0c24167 View commit details
    Browse the repository at this point in the history
  11. start/end for conv

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    548d16c View commit details
    Browse the repository at this point in the history
  12. fixing bugs

    SeahK committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    a3b497e View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. adding support for sw padding

    SeahK committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    820fcf8 View commit details
    Browse the repository at this point in the history
  2. sw padding support for conv fsm

    SeahK committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    91f7283 View commit details
    Browse the repository at this point in the history
  3. fixing bugs

    SeahK committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    9853765 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ec4e50 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. stride bug

    SeahK committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    144c880 View commit details
    Browse the repository at this point in the history
  2. stride bug

    SeahK committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    929ff92 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Bump gemmini-rocc-tests (#81)

    hngenc committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    d9237b5 View commit details
    Browse the repository at this point in the history
  2. added och division

    SeahK committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    d2420af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ce629d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2622d07 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    54449a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Configuration menu
    Copy the full SHA
    bccb2f6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #61 from ucb-bar/multiplex-scale

    Multiplex accumulator scaling
    hngenc committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    b631f0b View commit details
    Browse the repository at this point in the history
  3. Double-buffer conv layers that have pooling (#82)

    * Fix DMA perf bug
    
    * Update ROB so that fence is not required for pooling mvout
    
    * Add pooling support for conv-fsm
    
    * Fix pooling conv-fsm bug
    
    * Update SPIKE.hash
    
    * Bump gemmini-rocc-tests
    hngenc committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    8e262b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Only flush spatial array in OS mode (#85)

    Resnet50 utilization after this change: 41.7%
    hngenc committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    cc299e7 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Bump gemmini-rocc-tests (#88)

    hngenc committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    2f1b242 View commit details
    Browse the repository at this point in the history
  2. Make the internal conv-fsm truly weight-stationary (#86)

    Resnet50 utilization: 43%
    hngenc committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    2620d30 View commit details
    Browse the repository at this point in the history
  3. Split rob entries based off requested resources for efficiency (#73)

    * Split rob entries based off requested resources for efficiency
    
    * Condense ROB entries into 2 address slots per entry
    
    * Set ROB size back to original
    
    * Give LoopConv awareness of ROB size
    jerryz123 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    88279c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. merge dev change

    SeahK committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    2b0cfc9 View commit details
    Browse the repository at this point in the history
  2. pooling fixed

    SeahK committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    3c845e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Increase the throughput of matmuls in WS mode (#87)

    Resnet50 utilization: 46%
    hngenc committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b49679d View commit details
    Browse the repository at this point in the history
  2. Perform global-averaging on Gemmini (#90)

    ResNet50 utilization: 51%
    hngenc committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    d39b7b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Configuration menu
    Copy the full SHA
    0c6e603 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2021

  1. start working on profiling

    SeahK committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    3807665 View commit details
    Browse the repository at this point in the history
  2. adding profiler

    SeahK committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    b6e61ad View commit details
    Browse the repository at this point in the history
  3. fixing bugs

    SeahK committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    133a4d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. debugging

    SeahK committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    125192a View commit details
    Browse the repository at this point in the history
  2. debugging

    SeahK committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    4a982ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c5b02c View commit details
    Browse the repository at this point in the history
  4. debugging

    SeahK committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    8d3b214 View commit details
    Browse the repository at this point in the history
  5. debugging

    SeahK committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    cda843f View commit details
    Browse the repository at this point in the history
  6. adding more profile function

    SeahK committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    ca0fe4f View commit details
    Browse the repository at this point in the history
  7. added dontTouch

    SeahK committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    286d2a2 View commit details
    Browse the repository at this point in the history
  8. increase bitwidth

    SeahK committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    0f8eb29 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Configuration menu
    Copy the full SHA
    0533ccb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e71bbc View commit details
    Browse the repository at this point in the history
  3. fix how to calculate latency

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    45e9679 View commit details
    Browse the repository at this point in the history
  4. debugging

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    3ffa0d4 View commit details
    Browse the repository at this point in the history
  5. debugging, added reset signals

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    47323af View commit details
    Browse the repository at this point in the history
  6. debugging

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    d67ebe5 View commit details
    Browse the repository at this point in the history
  7. debugging

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    667ec2d View commit details
    Browse the repository at this point in the history
  8. debugging

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    f2966f0 View commit details
    Browse the repository at this point in the history
  9. added reset for translate enq

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    d2eeae4 View commit details
    Browse the repository at this point in the history
  10. more reset

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    ae3e381 View commit details
    Browse the repository at this point in the history
  11. debugging

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    99d89c8 View commit details
    Browse the repository at this point in the history
  12. remove division

    SeahK committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    9e946f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. add dw mapping

    SeahK committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    a6f4ccb View commit details
    Browse the repository at this point in the history
  2. looploader dw

    SeahK committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    98aa967 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cff3e4d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Configuration menu
    Copy the full SHA
    4de86ce View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. change stride

    SeahK committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    45f60d6 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. bump rocc-tests

    SeahK committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    91505b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2021

  1. start working on 2 out

    SeahK committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    5ebb224 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31c8ce0 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. debugging

    SeahK committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    ccea00c View commit details
    Browse the repository at this point in the history
  2. debugging

    SeahK committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    6994f37 View commit details
    Browse the repository at this point in the history
  3. debugging

    SeahK committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    3086b04 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. fixing looploader

    SeahK committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    6570b11 View commit details
    Browse the repository at this point in the history
  2. debugging

    SeahK committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    7ec19bc View commit details
    Browse the repository at this point in the history
  3. debugging

    SeahK committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    9f61b44 View commit details
    Browse the repository at this point in the history
  4. deleted counter

    SeahK committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    c107cb5 View commit details
    Browse the repository at this point in the history
  5. debugging

    SeahK committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    1a7fa4a View commit details
    Browse the repository at this point in the history
  6. changed latency

    SeahK committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    2cde9ce View commit details
    Browse the repository at this point in the history
  7. changed latency

    SeahK committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    60a1103 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. code for partial sum move out

    SeahK committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    123a980 View commit details
    Browse the repository at this point in the history
  2. stride for partial sum

    SeahK committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    e7feb86 View commit details
    Browse the repository at this point in the history
  3. debugging

    SeahK committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    f2d1841 View commit details
    Browse the repository at this point in the history
  4. fixing bias for loopconv

    SeahK committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    d54d314 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. changing bubble insertion part

    Seah Kim authored and Seah Kim committed May 4, 2021
    Configuration menu
    Copy the full SHA
    520268e View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. debugging

    Seah Kim authored and Seah Kim committed May 5, 2021
    Configuration menu
    Copy the full SHA
    e18f5c3 View commit details
    Browse the repository at this point in the history
  2. delete bubble enable signal

    Seah Kim authored and Seah Kim committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b1c38c4 View commit details
    Browse the repository at this point in the history
  3. add enable signal again

    Seah Kim authored and Seah Kim committed May 5, 2021
    Configuration menu
    Copy the full SHA
    0fcbe86 View commit details
    Browse the repository at this point in the history