Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split rob entries based off requested resources for efficiency #73

Merged
merged 7 commits into from
Mar 20, 2021

Conversation

jerryz123
Copy link
Contributor

No description provided.

@jerryz123 jerryz123 requested a review from hngenc March 8, 2021 02:27
@hngenc
Copy link
Member

hngenc commented Mar 8, 2021

Can you check how much area this frees up after synthesis?

@jerryz123
Copy link
Contributor Author

Can you check how much area this frees up after synthesis?

Probably not much, there is the same number of address hazard comparators. The difference is they are distributed among slightly more entries now.

@hngenc
Copy link
Member

hngenc commented Mar 8, 2021

I'm a little nervous about making this many changes to the ROB. Before we merge, can you make sure that this passes the resnet50 test and the bareMetalC tests on Firesim?

@jerryz123
Copy link
Contributor Author

I'm a little nervous about making this many changes to the ROB. Before we merge, can you make sure that this passes the resnet50 test and the bareMetalC tests on Firesim?

I won't have time to try this for a while, but I have high confidence in this code. Overall, very little logic in the ROB actually changed. Only the logic for selecting entries to allocate to, which didn't matter for functionality anyways.

@hngenc hngenc merged commit 88279c4 into dev Mar 20, 2021
@hngenc hngenc deleted the efficient-rob branch March 20, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants