Add generated clocks to clock API #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if this file was deliberately omitted from creation, but creating it prevents an infinite loop if the target depends on the stamp
Otherwise macro extraction scripts may fail.
As per Colin, apparently won't be a major source of problems
…r structure - Start of hammer-vlsi/"little hammer" structure - Port existing synthesis and place and route scripts to new structure - Get a working first pass with DC+saed32
Fix non-deterministic test
And support installs vs tarballs
Too often we need to know their lengths
edwardcwang
reviewed
Jun 21, 2018
| @@ -110,6 +110,9 @@ vlsi.inputs: | |||
| # period (TimeValue) - Clock port period. e.g. "1 ns", "5ns". Default units: ns | |||
| # port (str) - Optional. If specified, this is the RTL path to the clock. Otherwise, the path is the same as the name. | |||
| # uncertainty (TimeValue) - Optional. Clock uncertainty. e.g. "1 ns", "5ns". Default units: ns | |||
| # generated (bool) - Optional. If specified this clock is generated from another clock, must specify source_port and divisor | |||
| # source_port (str) - Required if generated. The port of the clock that this clock is generated from. | |||
| # divisor (int) - Required if generated. The amount this generated clock is slowed from the source clock e.g. 2 => this clock will be two times slower than the source clock. | |||
There was a problem hiding this comment.
-
is it worth renaming "port" to "path" for clock constraints?
-
Does the tool only support integer divisors?
There was a problem hiding this comment.
-
Doesn't matter to me either way. I'll change it (port is slightly too specific).
-
Yes. SDC supports only integers. It does also support multiplication but I don't have experience with that.
There was a problem hiding this comment.
Thanks for the explanation:
"SDC supports only integers. It does also support multiplication but I don't have experience with that." <-- can we add that as a comment to the file so we can remember this reasoning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relatively simple/straightforward API for generated clocks.
One could imagine an API that uses the source clock's name rather than port but I think these json/yml structures should be generated so thats not a big usability improvement?