Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for clock groups #481

Merged
merged 4 commits into from
Jul 26, 2019
Merged

Add basic support for clock groups #481

merged 4 commits into from
Jul 26, 2019

Conversation

colinschmidt
Copy link
Contributor

Fixes #59

jwright6323
jwright6323 approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@jwright6323 jwright6323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me- one comment nit but I would say it's non-blocking.

src/hammer-vlsi/defaults.yml Show resolved Hide resolved
edwardcwang
edwardcwang approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM modulo some nits

src/hammer-vlsi/hammer_vlsi/hammer_vlsi_impl.py Outdated Show resolved Hide resolved
src/hammer-vlsi/defaults.yml Outdated Show resolved Hide resolved
colinschmidt and others added 2 commits July 26, 2019 12:58
@colinschmidt @edwardcwang
Add comment nits
597e3d0 
Co-Authored-By: edwardcwang <edwardcwang@users.noreply.github.com>
@colinschmidt
Fix fix style nit
87dccbc
@colinschmidt colinschmidt merged commit 8997d17 into master Jul 26, 2019
@colinschmidt colinschmidt deleted the add-clock-groups branch July 26, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwright6323 jwright6323 jwright6323 approved these changes

@edwardcwang edwardcwang edwardcwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support clock groups in SDC
3 participants
@colinschmidt @jwright6323 @edwardcwang