Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle PublicEvent #19

Merged
merged 1 commit into from
Oct 15, 2021
Merged

handle PublicEvent #19

merged 1 commit into from
Oct 15, 2021

Conversation

ansh-saini
Copy link
Contributor

@ansh-saini ansh-saini commented Oct 15, 2021 •
edited by mattxwang
Loading

Closes #14
The user name and repository name (with links) is handled by the parent component :)

image

mattxwang
mattxwang approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work Ansh!

@mattxwang mattxwang merged commit 9f991a2 into uclaacm:main Oct 15, 2021
@ansh-saini
Copy link
Contributor Author

Hey @mattxwang. I noticed that this project is not having hacktoberfest in its topics. So it says "Project not participating" on the Hacktoberfest Dashboard.
Would you please add it?
image

@mattxwang
Copy link
Member

Hey @mattxwang. I noticed that this project is not having hacktoberfest in its topics. So it says "Project not participating" on the Hacktoberfest Dashboard. Would you please add it? image

Hi Ansh, I wasn't planning on tagging the entire repository in to Hacktoberfest, though I was planning on opting-in specific issues. I didn't realize the correct tag is hacktoberfest-accepted (and not hacktoberfest), so I've updated this PR accordingly. Can you check if the dashboard is properly updated now?

@ansh-saini
Copy link
Contributor Author

ansh-saini commented Oct 15, 2021 •
edited
Loading

Hey. Thanks for the quick response. Yes, the dashboard is updated and now this PR counts towards my contributions. Thank you so much Matt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process PublicEvent properly
2 participants
@ansh-saini @mattxwang