Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display midday booking as "12:00 pm" not "0:00 pm" #10

Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix: display midday booking as "12:00 pm" not "0:00 pm" #10

merged 1 commit into from
Oct 8, 2023

Conversation

olliestone
Copy link
Contributor

fixes #9

Copy link
Member

@shu8 shu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for finding and fixing this bug! :)

@shu8 shu8 merged commit d8a9fe4 into uclapi:master Oct 8, 2023
1 check passed
@shu8
Copy link
Member

shu8 commented Oct 8, 2023

@olliestone This is deploying to our staging environment at staging.enghub.io now.
Please could you make a random booking there and check it's working as expected for you now?

@olliestone
Copy link
Contributor Author

@shu8 I’m getting this error when trying to login on the staging environment so can’t book a room to check

{
    "ok": false,
    "error": "App does not exist for client id"
}

@shu8
Copy link
Member

shu8 commented Oct 9, 2023

@olliestone sorry about that, should be fixed now.

@olliestone
Copy link
Contributor Author

@shu8 can confirm it works as expected now
IMG_0446

@shu8
Copy link
Member

shu8 commented Oct 9, 2023

@olliestone Great! I've deployed this to production now.

Thanks again :)

@olliestone
Copy link
Contributor Author

@shu8 perfect, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room booked at midday displays as 0:00 pm
2 participants