Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fyyur Project: Add missing fields, fix broken pages, fix method that throws error, add edit buttons #117

Merged
merged 9 commits into from
Mar 16, 2021
Merged

Fyyur Project: Add missing fields, fix broken pages, fix method that throws error, add edit buttons #117

merged 9 commits into from
Mar 16, 2021

Commits on Feb 21, 2021

  1. Update new_artist.html 

    Fix broken form.  Change text on button to Artist, not venue. Correct facebook_link label.
    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    3f5d68c View commit details
    Browse the repository at this point in the history

  2. Add missing fields to new_artist.html

    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    7c8008f View commit details
    Browse the repository at this point in the history

  3. Add missing fields to forms.py

    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    0f888c6 View commit details
    Browse the repository at this point in the history

  4. Fix broken form and add missing fields

    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    f211510 View commit details
    Browse the repository at this point in the history

  5. Fix edit_artist.html 

    Add missing fields and fix the broken ones.
    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    a8da1d8 View commit details
    Browse the repository at this point in the history

  6. Fix edit_venue.html 

    Add missing fields and fix the broken ones.
    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    5a7a012 View commit details
    Browse the repository at this point in the history

  7. Add edit button to show_artist.html 

    Add missing button connected to the artist/<artist.id>/edit endpoint.  "Todo" instructions say to complete this endpoint, although the front end parts that are supposed to be complete do not use it.
    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    e0a9e82 View commit details
    Browse the repository at this point in the history

  8. Add edit button to show_venue.html 

    Added missing edit button to connect to the /venues/<venue.id>/edit endpoint.  The instructions say to complete this, but it is not used by the completed front end.  This will make it much easier for users to test the endpoint when they complete it.
    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    a67dbf5 View commit details
    Browse the repository at this point in the history

  9. Fix format_datetime method 

    Added missing "locale='en'" that causes a crash.
    @robinlamb
    robinlamb authored Feb 21, 2021
    Configuration menu
    Copy the full SHA
    25ff47d View commit details
    Browse the repository at this point in the history