Coref: Bridging and SplitAnte #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the mention is not reachable via `head.coref_mentions` and `len(mention.words) == 0`, which is both misleading.
We cannot access src_mention.head.root.coref_clusters when loading Bridging because these are not ready yet.
michnov
approved these changes
Feb 28, 2021
udapi/core/coref.py
Outdated
|
|
||
|
|
||
| class BridgingLinks(collections.abc.MutableSequence): | ||
| """BridgingLinks class serves as a list of BridgingLinks tuples with additional methods. |
udapi/core/coref.py
Outdated
Comment on lines
61
to
66
| @property | ||
| def bridging(self): | ||
| if self._bridging: | ||
| return self._bridging | ||
| self._bridging = BridgingLinks(self) | ||
| return self._bridging |
There was a problem hiding this comment.
Haven't we agreed that although the CoNLL-U representation of bridging will be a mention-to-cluster link, we should talk about it as a cluster-to-cluster relation and the same should hold for API?
There was a problem hiding this comment.
Apparently our agreement was mention-to-cluster, as you've implemented CorefCluster.all_bridging. Nevertheless, the reasons why we have decided to represent it as neither mention-to-mention nor for cluster-to-cluster, but mention-to-cluster, should be explained in the report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.