Skip to content

Bug fix. Use splice instead of default setting for form arrays in instance service. #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Bug fix. Use splice instead of default setting for form arrays in instance service. #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a90a3d
Fix for DynamicFormArray
Feb 26, 2019
9dcbb89
Merge branch 'development' of https://github.com/udos86/ng-dynamic-fo…
Karamuto Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/core/src/service/dynamic-form-instances-explicit.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,17 @@ describe("DynamicFormInstanceService test suite", () => {
expect(service.getFormControlInstance(model.id, 0)).toBe(instanceRef);
});

it("should no more have this reference at the given index, when deleted", () => {
it("should still have this reference at the given index, when deleting the first one", () => {
service.setFormControlInstance(model, instanceRef, 0);
service.setFormControlInstance(model, instanceRef, 1);
service.removeFormControlInstance(model.id, 0);
expect(service.getFormControlInstance(model.id, 0)).toBeDefined();
});

it("should no more have this reference at the given index, when deleting the first one two times", () => {
service.setFormControlInstance(model, instanceRef, 0);
service.setFormControlInstance(model, instanceRef, 1);
service.removeFormControlInstance(model.id, 0);
service.removeFormControlInstance(model.id, 0);
expect(service.getFormControlInstance(model.id, 0)).toBeUndefined();
});
Expand Down
12 changes: 8 additions & 4 deletions packages/core/src/service/dynamic-form-instances-explicit.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ export class DynamicFormInstancesExplicitService implements DynamicFormInstances

const arrayRef: Array<ComponentRef<DynamicFormControl>> =
this.formControlInstances[model.id] as Array<ComponentRef<DynamicFormControl>> || [];

arrayRef[index] = instance;

/**
* Use splice to add element
*/
arrayRef.splice(index, 0, instance);
this.formControlInstances[model.id] = arrayRef;

} else {
Expand All @@ -45,7 +46,10 @@ export class DynamicFormInstancesExplicitService implements DynamicFormInstances
if (index !== undefined) {

if (Array.isArray(instanceRef) && instanceRef[index]) {
instanceRef[index] = undefined;
/**
* Use splice to remove elements
*/
instanceRef.splice(index, 1);
} else {
throw new Error(`There exists no control with id: ${modelId} and/or index ${index}`);
}
Expand Down