Multi-platform support #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revisited PySide2 shipping and added build script. Windows build is still included for the time being.
Moved publish2 hooks from tk-config-unreal to the framework with supporting files.
|
Heads up that this PR has now further changes from our latest round of work: publish2 tk-maya hooks are now shipped with this framework rather than with tk-config-unreal to allow easy updates of the config. |
000paradox000
suggested changes
Dec 3, 2021
| "python", | ||
| "vendors", | ||
| "py%d" % python_major, | ||
| pname, |
There was a problem hiding this comment.
Just to double check, currently there's not python/vendors folder and base_path is the root path of the framework?
There was a problem hiding this comment.
Yes, there was only the Windows binaries, that I removed for the CR.
| "site-packages" | ||
| ) | ||
|
|
||
| os.environ["VIRTUAL_ENV"] = base_path |
There was a problem hiding this comment.
A friendly request: can you explain a little bit the strategy with virtualenv?. It's not usual in toolkit play with virtualenv specially when distributing components
hooks/tk-multi-publish2/tk-maya/unreal/unreal_setup_turntable.py
Outdated
Show resolved
Hide resolved
hooks/tk-multi-publish2/tk-maya/unreal/unreal_setup_turntable.py
Outdated
Show resolved
Hide resolved
|
Closing in favor of the PR against gpltech branch |
ryanmayeda
pushed a commit
that referenced
this pull request
Jul 12, 2024
* For #13673, support for Maya 2025 Removed all six dependencies. Added support for PySide6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisited PySide2 shipping and added build script.
Added Azure pipeline script to build releases for Windows, Osx and Linux.
Note: Windows build is still included for the time being.