Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for building gpgme with musl >= 1.2.4 #181

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

jk779
Copy link
Contributor

@jk779 jk779 commented Jan 16, 2024

When trying to compile this with a current alpine linux, the build fails because of an upgrade of musl. musl 1.2.4 removed the LFS64 interfaces, which are used in gpgme. They provide a way to reenable them until sources are updated with CFLAGS=-D_LARGEFILE64_SOURCE.

This adds the workaround to the build config until gpgme updates their code.

Here's a stacktrace of the installation without this patch: https://gist.github.com/jk779/33a16851bbe3c6baf7a024eba1fb7dc3


See #182

Copy link
Owner

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to having this workaround; have you notified the gpgme people already?

@jk779
Copy link
Contributor Author

jk779 commented Jan 17, 2024

@ueno they don't seem to use github but a mailing list, which is a way of communication i've never participated in ;) Thus I've procrastinated on this up to now. Feel free, if you're familiar with the etiquette in mailing lists 😬 🙈

@jjb
Copy link

jjb commented Jan 22, 2024

thank you @jk779!!

would be great to get this into a release

@ueno ueno merged commit 238a081 into ueno:master Jan 23, 2024
4 checks passed
@jjb
Copy link

jjb commented Jan 23, 2024

thanks for the merge! do you foresee a release coming up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants