Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIM: Sandbox Simulator Part 1 #83

Merged
merged 16 commits into from
Oct 31, 2016
Merged

SIM: Sandbox Simulator Part 1 #83

merged 16 commits into from
Oct 31, 2016

Conversation

sentree
Copy link
Member

@sentree sentree commented Oct 12, 2016

I am splitting up the simulator sandbox into two separate PRs due to popular demand. This PR contains functional versions of the following challenges:

  • Demonstrate Navigation and Control
  • Find Totems and Avoid Obstacles
  • Identify Symbols and Dock
  • Scan the Code
  • Detect and Deliver
  • Acoustic Pinger-Based Transit (actual pinger not yet implemented)

In the next PR, I will be making changes to complete the following challenges:

  • Identify Symbols and Dock (fixing the lighting issues)
  • Scan the Code (adding the platform and three faces)
  • Coral Survey
  • Find the Break

This list is currently in an order governed by increasing difficulty to implement. I would prefer that it be in an order governed by priority, so feedback as to what needs to be tested sooner rather than later would be nice.

Copy link
Member

@mattlangford mattlangford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by just adding the flag in the first comment everything will be good to go (assuming everything still runs which I'm sure it does)

-x 4 -y -18 -z 1.5 -model blue_cross"

<!-- Demonstrate Navigation and Control -->
<node name="spawn_speed_start_green" pkg="gazebo_ros" type="spawn_model"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a flag in here so that gazebo can be launched like: roslaunch navigator_launch simulation minimal:=true and it won't spawn all the obstacles?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you might look into just moving this into a python script that can randomly spawn things (that way this file isn't 5 miles long) (The first comment is more important than this but just an idea)

@kev-the-dev
Copy link
Contributor

kev-the-dev commented Oct 16, 2016

I noticed there are no changes to wamv.sdf in this PR. In the current version, there are some problems with the model. For example, the right camera is on the left side. The locations of the sensors as well (lidar, cameras) do not seem to be the same as we have in our TFs either. Will these be addressed in the sim?

@sentree
Copy link
Member Author

sentree commented Oct 18, 2016

I am waiting for the new sensor mast to be installed before correcting all of the measurements for the sensors. I can temporarily move the right camera for this PR if need be. Did you manage get it to the proper location when you were using my fork last week? If so, post the pose here.

@kev-the-dev
Copy link
Contributor

At least for X,Y,Z I think it should be the exact same as the TF, assuming they are both relative to the same point (measurement). I think waiting for the new mast is fine.

@kev-the-dev
Copy link
Contributor

@whispercoros @mattlangford what's holding this up? Are all the requested changes addressed? It would be nice to have this in the main repo so I can use

@mattlangford
Copy link
Member

mattlangford commented Oct 28, 2016

Not addressed, @whispercoros needs to add a way to launch the sim without spawning all the models so that our petty laptops can run the sim without cooking eggs

@sentree
Copy link
Member Author

sentree commented Oct 28, 2016

My apologies @ironmig, I thought I had taken care of this PR. I have the changes sitting on the Samba server in MIL and will push them tomorrow.

@sentree sentree force-pushed the simulation branch 2 times, most recently from b649be9 to 6e6dac1 Compare October 29, 2016 00:14
@sentree
Copy link
Member Author

sentree commented Oct 31, 2016

This can be merged once Semaphore finishes building it.

@mattlangford mattlangford merged commit 1651953 into uf-mil:dev Oct 31, 2016
RustyBamboo pushed a commit to RustyBamboo/NaviGator that referenced this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants