-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tf/optimization #11
Tf/optimization #11
Conversation
focuser = Maximizer( | ||
motor["position"], feedback, 10 * q.mm, epsilon=1e-3) | ||
focuser = Maximizer(motor["position"], feedback, algorithms.halver, | ||
(motor["position"], 10 * q.mm, self.epsilon), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only thing that bothers me with the changes. The maximizer already knows that position
has to be optimized, hence it should be possible that the maximizer passes this information to the actual algorithm. For me it looks a bit redundant to pass the Parameter object twice.
If we could improve this, I would'n object to merge this into master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, the halver was too simple and required a real x position at a time, because of the fact the f(x) domain is not infinite thanks to limiters. I improved the algorithm, so now it follows the general optimization algorithm signature: alg(x_0, *args, **kwargs)
, where x_0
is a value, not a parameter. This way our optimizers stay fairly general.
…eral optimization algorithms scheme.
Optimization is now a little bit more rich on algorithms.