Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid addon reattachment #391

Merged
merged 2 commits into from
May 31, 2016
Merged

Forbid addon reattachment #391

merged 2 commits into from
May 31, 2016

Conversation

tfarago
Copy link
Contributor

@tfarago tfarago commented May 30, 2016

If attached more times, addons cause trouble. This prevents that without the Addon developers needing to care about that.

@tfarago tfarago force-pushed the forbid-addon-reattachment branch from 6a43385 to 2c0a1e6 Compare May 30, 2016 14:00
@tfarago
Copy link
Contributor Author

tfarago commented May 30, 2016

@MarcusZuber once this is merged please check the test session again, for me it works now.

@tfarago tfarago force-pushed the forbid-addon-reattachment branch from 2c0a1e6 to 59f5475 Compare May 30, 2016 14:23
@tfarago tfarago self-assigned this May 30, 2016
@tfarago
Copy link
Contributor Author

tfarago commented May 31, 2016

@matze is this OK?

@matze
Copy link
Contributor

matze commented May 31, 2016

Yeah, go ahead 👍

@tfarago tfarago merged commit 3f61815 into master May 31, 2016
@tfarago tfarago deleted the forbid-addon-reattachment branch May 31, 2016 14:33
@matze matze removed the ready label May 31, 2016
@MarcusZuber
Copy link
Member

Oh, I was to slow... But its working fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants