Skip to content

fix: use value length to detect completion #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: use value length to detect completion #20

merged 1 commit into from
Nov 2, 2021

Conversation

krazibit
Copy link
Contributor

This fixes the issue of onCompleted is not being triggered when placeholder is set to empty string.

@krazibit krazibit mentioned this pull request Oct 27, 2021
Closed
@ugogo
Copy link
Owner

ugogo commented Nov 2, 2021

Hey @krazibit, thanks for the fix!

@ugogo ugogo merged commit dd97554 into ugogo:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krazibit @ugogo