-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamped UI Design of on-boarding page #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's recommended not to edit .idea files and the like @theGeekyLad
Just incase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a link to the contributors in the README.md
which github updates automatically
You might have to drop this file @theGeekyLad
Impressive @theGeekyLad kudos to you on a good job👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @theGeekyLad 👌
@theGeekyLad it is also important to note that PRs should focus on a single issue. |
Thanks a bunch for your review comments @ugwulo ! Helps a lot for a newbie like me indeed. Should I raise another PR with the udpated |
Yea sure, do well to raise another PR @theGeekyLad |
Also, is there a test reg. no. that I could use to sign in and check the other screens too? |
Yes, here it is 18EH/0059/CS @theGeekyLad |
Hey @ugwulo , thanks for the ID for testing. 😄 Also, I've dropped the unnecessary files. Is this PR good to go? |
Highlights
holder.binding.rootView ...
inHomeFragment.java
underonBindViewHolder()
, thatrootView
is has onlyprivate
access - updated that toholder.binding.getRoot ...
TextView
s,EditText
s etc. with Material componentsactivity_onboading.xml
to match standardsbtnVerify
inOnboardingActivity.java
which is automatically disabled ifeditRegNum
oreditStaffId
is emptytextColor
fromactivity_onboarding.xml
to fix issues in dark modeScreenshots
Light Mode
Dark Mode