Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped UI Design of on-boarding page #31

Merged
merged 10 commits into from
Oct 5, 2020
Merged

Revamped UI Design of on-boarding page #31

merged 10 commits into from
Oct 5, 2020

Conversation

theGeekyLad
Copy link
Contributor

Highlights

  • Fixed build throwing an error at holder.binding.rootView ... in HomeFragment.java under onBindViewHolder(), that rootView is has only private access - updated that to holder.binding.getRoot ...
  • Added official Material Design dependencies and replaced existing TextViews, EditTexts etc. with Material components
  • Changed look and feel of activity_onboading.xml to match standards
    • Based on whether student or staff, edit fields are shown / hidden
    • Added validation to btnVerify in OnboardingActivity.java which is automatically disabled if editRegNum or editStaffId is empty
  • Removed textColor from activity_onboarding.xml to fix issues in dark mode

Screenshots

Light Mode

light

Dark Mode

dark

@theGeekyLad theGeekyLad mentioned this pull request Oct 2, 2020
Copy link
Owner

@ugwulo ugwulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended not to edit .idea files and the like @theGeekyLad
Just incase

Copy link
Owner

@ugwulo ugwulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a link to the contributors in the README.md
which github updates automatically
You might have to drop this file @theGeekyLad

@ugwulo
Copy link
Owner

ugwulo commented Oct 2, 2020

Impressive @theGeekyLad kudos to you on a good job👍
Please do well to address the issue I pointed out

Copy link
Owner

@ugwulo ugwulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @theGeekyLad 👌

@ugwulo
Copy link
Owner

ugwulo commented Oct 2, 2020

@theGeekyLad it is also important to note that PRs should focus on a single issue.
Feel free to submit different PRs for other issues for easy tracking

@theGeekyLad
Copy link
Contributor Author

Thanks a bunch for your review comments @ugwulo ! Helps a lot for a newbie like me indeed. Should I raise another PR with the udpated README.md?

@ugwulo
Copy link
Owner

ugwulo commented Oct 3, 2020

Yea sure, do well to raise another PR @theGeekyLad

@theGeekyLad
Copy link
Contributor Author

Also, is there a test reg. no. that I could use to sign in and check the other screens too?

@ugwulo
Copy link
Owner

ugwulo commented Oct 4, 2020

Yes, here it is 18EH/0059/CS @theGeekyLad

@theGeekyLad
Copy link
Contributor Author

Hey @ugwulo , thanks for the ID for testing. 😄 Also, I've dropped the unnecessary files. Is this PR good to go?

@ugwulo ugwulo merged commit 74e6dc5 into ugwulo:main Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants