Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advise.after() (etc.) returned object missing destroy() method #25

Closed
wkeese opened this issue Jun 23, 2018 · 0 comments
Closed

advise.after() (etc.) returned object missing destroy() method #25

wkeese opened this issue Jun 23, 2018 · 0 comments
Assignees
@uhop
Labels
bug confirmed

Comments

@wkeese
Copy link

wkeese commented Jun 23, 2018 •
edited
Loading

DCL v1's advise.after() etc. methods returned an object with a destroy() method, but DCL v2's methods return an object with just unadvise() and remove().

According to http://www.dcljs.org/2.x/docs/advise_js/after/ there should still be a destroy() method in v2. Additionally, it would be convenient to use with Cleanable#pushCleanup().
@wkeese wkeese mentioned this issue Jun 24, 2018
Closed
wkeese added a commit to wkeese/decor that referenced this issue Jun 24, 2018
@wkeese
Upgrade to DCL V2.
37a34da 
Depends on DCL fixes uhop/dcl#25 and uhop/dcl#26not yet released.
@uhop uhop self-assigned this Jun 24, 2018
@uhop uhop added the bug label Jun 24, 2018
@uhop uhop closed this as completed in 630eba7 Jun 24, 2018
@uhop uhop added the confirmed label Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uhop uhop

Labels
bug confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uhop @wkeese