Major Improvements 2 #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for another PR! Unlike the previous (closed) one, this PR should be mergeable without any external actions required.
This PR brings type safety to typed array and extends #7 to the
find
andfindIndex
methods.Introduces a single utility type
CheckNonNullable
, which is unnecessary with the type ofo
being replaced to{}
after TypeScript 4.8 due to microsoft/TypeScript#49119.The first parameter of
{Array, %TypedArray%}.from
are all renamed tosource
because writingiterable: Iterable<T> | ArrayLike<T>
is kind of misleading, and it is also namedsource
in the spec text.This PR does not include tests for methods with only
thisArg
changes, or it will be superfluous.I think some bugs like
this: void
in the original library files should be reported to TypeScript, and I am surprised that the return type of the first parameter of the%TypedArray%.prototype
methods in the originales2020.bigint.d.ts
file are already typedboolean
, in contrast to theArray.prototype
methods ines5.d.ts
.