Skip to content

add math.charCodeAt #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

add math.charCodeAt #2

wants to merge 14 commits into from

Conversation

taisukef
Copy link

@taisukef taisukef commented Apr 27, 2021

#1

<abbr><math><charCodeAt/></math><br>abc<br>0</abbr>

→ 97

@uhyo
Copy link
Owner

uhyo commented Apr 27, 2021

Hello, thank you for your PR.
Unfortunately, addition of <charCodeAt /> to the math namespace cannot be accepted because it is not valid per the HTML syntax. Specifically there is no charCodeAt element defined in the MathML Spec.

It seems that we need more namespaces and a generic way of importing from namespaces. Maybe <q cite="string/charCodeAt"></q> or something... 🤔
If you can wait for a couple of days, I will add this.

@taisukef
Copy link
Author

It's important to follow the HTML specifications!
Thank you for the detailed explanation.

@taisukef
Copy link
Author

taisukef commented Apr 27, 2021

I added Q tag instead of math.charCodeAt.

<q cite="string/charCodeAt">abc<br>0</q>

→ 97

@uhyo
Copy link
Owner

uhyo commented Apr 28, 2021

Thank you for fast work!

However, I'd like to expect <q> to be something similar to <math>, not another function call expression. So it should be:

<abbr><q cite="string/charCodeAt"></q><br>abc<br>0</abbr>

If you don't mind, could you change the implementation like this? 🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants