ctrl / command + click open new window not working anymore.

[mkoczorowski]

Hi guys, I have noticed that ctrl / command + click open new window not working anymore on a link with uisref on it. Were there any changes to the behaviour? this is such an important and common thing

[christopherthielen]

Are you sure it used to work?

Seems like a good enhancement. Here's how we do it in AngularJS, and it should be very similar for Angular: https://github.com/angular-ui/ui-router/blob/3ab38264672cc820af539ead89e7a52370c68503/src/directives/stateDirectives.ts#L73

[mkoczorowski]

can this be achieved without modifying core ui-router code?

[christopherthielen]

Yes, this would be part of @uirouter/angular not @uirouter/core, likely right around this area:

angular/src/directives/uiSref.ts

Lines 170 to 178 in bfa604c

	/** When triggered by a (click) event, this function transitions to the UISref's target state */
	go() {
	if (this._anchorUISref && this._anchorUISref.openInNewTab()) {
	return ;
	}
	this._router.stateService.go(this.state, this.params, this.getOptions());
	return false;
	}

The go() function is a click handler. It should be modified to receive the click event and check if the proper keys are being held down.

[mkoczorowski]

thanks, I will look int o this when I have time

[euangoddard]

I have been looking into this issue and it should be possible to solve in the same way Angular's router does it. I've been trying to put together a PR, but when I follow the instructions to get the project up and running npm install fails inside the angular package.

npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod
npm ERR! enoent ENOENT: no such file or directory, chmod '/Users/euan/Sites/uirouter/angular/node_modules/@uirouter/publish-scripts/update_changelog.js'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

I can't find any way to work around this problem.

[euangoddard]

I have submitted a PR without being able to test the code (or writing any unit tests). If you can suggest a way of solving the issue I mentioned above, I'll be happy to add the tests!

[christopherthielen]

I know how to fix that problem. that was due to a bad release of @uirouter/publish-scripts so we just need to bump the dependency

[christopherthielen]

@euangoddard I bumped the package dependency. It should install and test fine now. I'm merging your PR as-is. Would you mind updating and adding a couple of tests as a new PR?

[euangoddard]

@christopherthielen thanks for merging this in. I've added the tests to cover these cases in: #176