Skip to content

[Ng2LocationConfig] get baseHref from LocationStrategy. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2017
Merged

[Ng2LocationConfig] get baseHref from LocationStrategy. #33

merged 1 commit into from
Jan 23, 2017

Conversation

aitboudad
Copy link
Contributor

No description provided.

@christopherthielen
Copy link
Member

Can you check the failed build?
https://travis-ci.org/ui-router/ng2/jobs/194437588

Looks like locationStrategy should be _ locationStrategy

@aitboudad
Copy link
Contributor Author

it should pass now

@christopherthielen christopherthielen merged commit fcf7ee3 into ui-router:master Jan 23, 2017
@christopherthielen
Copy link
Member

Thanks a lot!
Did this bug break your app?

@aitboudad aitboudad deleted the location-config branch January 23, 2017 12:48
@christopherthielen christopherthielen added this to the 1.0.0-beta.5 milestone Jan 23, 2017
@christopherthielen christopherthielen mentioned this pull request Jan 23, 2017
Closed
@aitboudad
Copy link
Contributor Author

yep, in angular-universal but I'm using a workaround right now until 1.0.0-beta.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.0-beta.5
Development

Successfully merging this pull request may close these issues.
2 participants
@aitboudad @christopherthielen