Skip to content

feat(Ng2LocationConfig): use BrowserLocationConfig. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2017
Merged

feat(Ng2LocationConfig): use BrowserLocationConfig. #50

merged 1 commit into from
Feb 12, 2017

Conversation

aitboudad
Copy link
Contributor

No description provided.

@christopherthielen
Copy link
Member

when i first wrote this I couldn't find an abstraction in Angular that exposes the "LocationConfig" stuff. I take it you came to the same conclusion?

Is your proposal that in universal people simply replace the config with the memory config?.

@aitboudad
Copy link
Contributor Author

yep

@christopherthielen
Copy link
Member

works for me.

@christopherthielen christopherthielen merged commit 7b70b4a into ui-router:master Feb 12, 2017
@aitboudad aitboudad deleted the location branch February 12, 2017 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitboudad @christopherthielen