-
Notifications
You must be signed in to change notification settings - Fork 138
refactor: remove unsupported Angular imports #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Angular v13 removes the deprecated `loadChildren: string` syntax as well as the supporting `NgModuleFactoryLoader` and `SystemJsNgModuleLoader`. This commit simply removes those imports and providers. None of the examples or tests appear to be using the `loadChildren: string` syntax. In fact, the `Ng2StateDeclaration.loadChildren` does not even have `string` as a valid type in `ModuleTypeCallback`. See angular/angular@361273f fixes ui-router#949
Will you have a plan to merge that PR? |
I think package.json should be updated too for have the newest version there too |
minimal change makes for a faster release. would love to see this merged! |
@kilatib, What @mokipedia said is the goal I was going for. I don't want to touch anything more than is absolutely necessary. These imports are leftover from old implementations and all we need to do is remove them to make everything happy. |
Hello, Angular 13 is here ;) |
@atscott Do you know a way how I could hardly set the higher angular version in my package.json to avoid conflict version with that repo? |
Hello @christopherthielen , What do you think about a new release with this change supporting Angular 13. |
Hello @antur84, may you please review the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are still green, LGTM
Sure they look fine to me, tests are green. But I'm not in a position to merge & release this, I'm a humble consumer of the lib :) |
Ahh, sorry :) |
A merge of this would be so appreciated. We are blocked from upgrading to v13 currently |
I'll release a new version as soon as I can, thanks for the PR! |
@christopherthielen i also willing to preapare PR with version bump and explicit support of ng13 + test The ng13 introduced new way of distributing packages and it would be nice to build this library with actual versions of ng-packagr and angular compiler. So it's probably would be better to wait for my PR and make release of all together |
Hello @thekip, As pointed out by @mokipedia and the change made by @atscott, the idea behind this change was "minimal change makes for a faster release." |
Angular v13 removes the deprecated
loadChildren: string
syntax as wellas the supporting
NgModuleFactoryLoader
andSystemJsNgModuleLoader
.This commit simply removes those imports and providers. None of the
examples or tests appear to be using the
loadChildren: string
syntax.In fact, the
Ng2StateDeclaration.loadChildren
does not even havestring
as a valid type inModuleTypeCallback
.See angular/angular@361273f
fixes #949