Skip to content

Documentation and typings do not match #79

@eseliger

Description

@eseliger

The documentation says here in the text that every value in the views object must be a Ng1ViewDeclaration. Although, in the example a string is used as well, which works. But the type for views is

views?: {
    [key: string]: _ViewDeclaration;
}

I think the type of values should be _ViewDeclaration | string

Also in StateDeclaration, the return type of redirectTo currently is

RedirectToResult | ((transition: Transition) => Promise<RedirectToResult>);

although the documentation says here it can either be a RedirectToResult, or a function returning either a Promise or a RedirectToResult. So I think it should be

RedirectToResult | ((transition: Transition) => RedirectToResult | Promise<RedirectToResult>);

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions