Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing priority as string #25

Merged
merged 4 commits into from
Aug 26, 2013

Conversation

yprez
Copy link
Contributor

@yprez yprez commented Aug 21, 2013

According to the tutorial, send() should accept the string representation of priority.
Ref #23

@@ -56,6 +56,13 @@ def send(recipients, sender=None, template=None, context={}, subject='',
if sender is None:
sender = settings.DEFAULT_FROM_EMAIL

if isinstance(priority, (str, unicode)):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using basestring instead of (str, unicode) is better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thought this was more clear...

selwin added a commit that referenced this pull request Aug 26, 2013
Allow passing priority as string, thanks to @yprez. Fixes #23
@selwin selwin merged commit a4ea24c into ui:master Aug 26, 2013
@yprez yprez deleted the fix_string_priority_representation branch February 16, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants