You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the awesome library. Saves lots of time from writing these hooks from scratch. I was a little bit disappointed there weren't Typescript type definitions and had to add declarations for the few hooks I am currently using. So I added types for all the hooks in the library (excluding the experimental hooks).
Nice job! But I have a proposal, why not rewrite the hooks with TypeScript? I believe this could bring a better DX, I'm open to work on it if this is wanted
Nice job! But I have a proposal, why not rewrite the hooks with TypeScript? I believe this could bring a better DX, I'm open to work on it if this is wanted
I feel like this is more work than it's worth right now, this solution is a stop-gap solution in the meanwhile and it should be merged.
Nice job! But I have a proposal, why not rewrite the hooks with TypeScript? I believe this could bring a better DX, I'm open to work on it if this is wanted
I feel like this is more work than it's worth right now, this solution is a stop-gap solution in the meanwhile and it should be merged.
I agree, this should be merged first in the meantime.
Nice job! But I have a proposal, why not rewrite the hooks with TypeScript? I believe this could bring a better DX, I'm open to work on it if this is wanted
I 100% agree this would be the ideal approach but I wanted something quick to start with just as @ariesclark highlighted as well. I can take some time over the weekend to re-write the hooks with Typescript.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome library. Saves lots of time from writing these hooks from scratch. I was a little bit disappointed there weren't Typescript type definitions and had to add declarations for the few hooks I am currently using. So I added types for all the hooks in the library (excluding the experimental hooks).