Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show groups when any filtered results in group #14505

Merged

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 5, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

As we start getting more blocks in Block List / Block Grid editor and thus creating several groups, we may end up with empty groups when filtering these in block picker.

I think it is cleaner only to show each group, which has any filtered result - currently it check filtered results in any group (or non-grouped blocks).

I also updated search term filtering to be consistent with other freetext filtering, where we have a searchTerm as property on a filter object.

chrome_P35gRfNcZ7

Result

chrome_IbDVgLugYZ.mp4

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @bjarnef, thanks for the PR! Someone on the core collaborators team will review this soon 😄

@georgebid georgebid self-requested a review July 6, 2023 08:48
@georgebid georgebid merged commit 0c595cc into umbraco:contrib Jul 6, 2023
@georgebid
Copy link
Contributor

Hey, again! I have now tested your PR and all looks good to me, a nice feature 💯 I have now merged this in. Thanks @bjarnef!

@bjarnef bjarnef deleted the feature/block-picker-filter-groups branch July 6, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants