Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14: Update DataTypeControllerBase to use GetAllAsync() #15641

Merged
merged 3 commits into from
Jan 31, 2024
Merged

V14: Update DataTypeControllerBase to use GetAllAsync() #15641

merged 3 commits into from
Jan 31, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Jan 26, 2024

Fixes: #15624

Notes

  • Updated to use GetAllAsync instead of GetAll 👍
  • Obsoleted GetAll()

How to test

  • Follow steps in original issue

@Zeegaan Zeegaan added the project/bellissima AKA "the new backoffice" label Jan 26, 2024
elit0451
elit0451 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 💪 Will merge soon

@elit0451 elit0451 merged commit 0dd2beb into v14/dev Jan 31, 2024
15 checks passed
@elit0451 elit0451 deleted the v14/bugfix/make-data-type-controller-base-use-async branch January 31, 2024 14:00
@elit0451 elit0451 mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elit0451 elit0451 elit0451 approved these changes

Assignees
No one assigned
Labels
project/bellissima AKA "the new backoffice" release/14.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeegaan @elit0451 @bergmania