Skip to content

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Feb 9, 2024

Description

This enables sorting on document type tabs, groups, and properties.

Features:

  • Can now set sortOrder manually via the input fields for all three: tabs, groups, properties.
  • Slightly changed some html structure to setup sorting
  • Sort tabs by dragging
  • Sort groups by dragging
  • Sort properties by dragging

Missing/Notes:

  • Inherited items can still be moved, though it doesn't actually save. Inherited items should be able to be moved.
  • Some items shows up as a local despite actually being inherited. This is a bug in document types and this causes some confusion when using the sorter, making it feel broken.
  • Some local items will show up as a inherited item when moved to a different group.
  • Calculation of the sortOrder is currently incorrect. See this PR

Issues with inheritage/composition will be fixed after document type gets its compositions fixed (PBI on the issue is created)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@loivsen loivsen marked this pull request as draft February 9, 2024 09:44
@loivsen loivsen marked this pull request as ready for review February 15, 2024 12:21
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iOvergaard iOvergaard merged commit 02546fc into main Feb 16, 2024
@iOvergaard iOvergaard deleted the feature/document-type-sorting branch February 16, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants