Feature: Media Section View #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekelleher
requested review from
iOvergaard,
madsrasmussen and
nielslyngsoe
|
Followed up with @madsrasmussen, the use of "media-management" pathname for the section is acceptable (for the time being). We can review at a later stage. |
I need to check with @madsrasmussen and @nielslyngsoe if we still need the "dashboardCollection" extension type in the codebase? (As I can't see where else it was being used.)
This is to follow consistency with the members/users sections. My gut feeling is that I'm off with this, and need to sanity check with @madsrasmussen and @nielslyngsoe.
to display the Media Collection component. The `umb-media-section-view` component is still a work-in-progress. It needs to have the default collection data-type configuration wired up.
leekelleher
force-pushed
the
feature/media-section-view
branch
from
9a57c89 to
b74edab
Compare
iOvergaard
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd appreciate a sanity check on these changes from @madsrasmussen and @nielslyngsoe, to make sure it is on the right track. Personally, I'm not 100% happy with the "media-management" section path.