Skip to content

Conversation

nathanwoulfe
Copy link
Contributor

Noticed when scrolling content or datatype views in vertical layout the editor was visible behind the header. These changes add a background to the header and a pseudo-element to mask overflow.

Also tightens whitespace in workspace-property-layout to ensure even whitespace above and below all instances (reduces padding when element is in a content node as the containing box adds padding-Y).

Finally, tweaks TinyMCE styles to match editor borders from UUI - ie squared corners, color, border width.

@nathanwoulfe nathanwoulfe enabled auto-merge June 26, 2023 01:51
@iOvergaard iOvergaard requested a review from nielslyngsoe June 26, 2023 07:53
@nielslyngsoe
Copy link
Member

Hi @nathanwoulfe I really love your focus on the details and love your effort to bring everything to a production ready quality.
I do though have a bit of comments on the way these have been carried out. And I hope you will appreciate my corrections, as learning into how we separate concerns with Web Components, more specifically Shadow DOM.

I hope my comment in the code will survive though I will be correcting the code as well. :-)

@nielslyngsoe nielslyngsoe disabled auto-merge June 29, 2023 19:09
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanwoulfe
Please read my comments, see the changes I made, and check if you are happy with the PR.

I disabled auto-merge so you can approve it this way. And I have approved the PR. So Just merge if you are happy :-)

@nathanwoulfe
Copy link
Contributor Author

Thanks Niels, that all makes sense - appreciate your holistic view of how this all works together 😄

@nathanwoulfe nathanwoulfe merged commit 170f9d6 into main Jul 2, 2023
@nathanwoulfe nathanwoulfe deleted the chore/ui-styles branch July 2, 2023 23:59
@nielslyngsoe nielslyngsoe restored the chore/ui-styles branch July 3, 2023 11:32
@iOvergaard iOvergaard deleted the chore/ui-styles branch September 15, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants