-
Notifications
You must be signed in to change notification settings - Fork 59
Chore/UI styles #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/UI styles #791
Conversation
Hi @nathanwoulfe I really love your focus on the details and love your effort to bring everything to a production ready quality. I hope my comment in the code will survive though I will be correcting the code as well. :-) |
src/packages/core/workspace/workspace-property-layout/workspace-property-layout.element.ts
Outdated
Show resolved
Hide resolved
src/packages/core/workspace/workspace-property-layout/workspace-property-layout.element.ts
Outdated
Show resolved
Hide resolved
src/packages/core/workspace/workspace-property-layout/workspace-property-layout.element.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nathanwoulfe
Please read my comments, see the changes I made, and check if you are happy with the PR.
I disabled auto-merge so you can approve it this way. And I have approved the PR. So Just merge if you are happy :-)
Thanks Niels, that all makes sense - appreciate your holistic view of how this all works together 😄 |
Noticed when scrolling content or datatype views in vertical layout the editor was visible behind the header. These changes add a background to the header and a pseudo-element to mask overflow.
Also tightens whitespace in
workspace-property-layout
to ensure even whitespace above and below all instances (reduces padding when element is in a content node as the containing box adds padding-Y).Finally, tweaks TinyMCE styles to match editor borders from UUI - ie squared corners, color, border width.