Skip to content

Remove tokens in INSTALL state #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2023
Merged

Remove tokens in INSTALL state #792

merged 2 commits into from
Jun 27, 2023

Conversation

iOvergaard
Copy link
Collaborator

@iOvergaard iOvergaard commented Jun 27, 2023 •
edited
Loading

Description

Due to needs from the backend, we should not store any tokens on the installer, since they will be invalid anyway.

Changes

  • extract auth initialization to another method and only invoke it if we are not in INSTALL state
  • clear any cached tokens if we are in INSTALL state

@iOvergaard iOvergaard enabled auto-merge June 27, 2023 07:16
@iOvergaard iOvergaard requested a review from nielslyngsoe June 27, 2023 07:38
nielslyngsoe
nielslyngsoe approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@iOvergaard iOvergaard merged commit e0d2027 into main Jun 27, 2023
@iOvergaard iOvergaard deleted the feature/no-tokens-on-installer branch June 27, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iOvergaard @nielslyngsoe