-
Notifications
You must be signed in to change notification settings - Fork 59
Feature/partial views #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To align with repository interface
You can now update existing partial views, yay!
iOvergaard
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CRUD UI for partial views & folders.
Almost everything works against the real API except:
tree does not refresh when you remove a folder or file, I have no idea why, it's the same request that works once and is not done the other time.
There is a nasty, hacky solution in this PR to distinguish between file, folder and empty folder and display different actions. I think the conditions array in manifests you should be able to also pass a function, not only an alias - maybe a condition instead of being an array of strings should be an array of
Condition
interface that will have analias
and optionalfiletrFuction
that will be run every time you should determine if the extension should show up or not? Anyway, there is an urgent need for something nicer then what I have done in here, cause what I have done is quite dumb :)Description
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist