Skip to content

Conversation

julczka
Copy link
Contributor

@julczka julczka commented Jul 18, 2023

This PR adds CRUD UI for partial views & folders.
Almost everything works against the real API except:
tree does not refresh when you remove a folder or file, I have no idea why, it's the same request that works once and is not done the other time.
There is a nasty, hacky solution in this PR to distinguish between file, folder and empty folder and display different actions. I think the conditions array in manifests you should be able to also pass a function, not only an alias - maybe a condition instead of being an array of strings should be an array of Condition interface that will have an alias and optional filetrFuction that will be run every time you should determine if the extension should show up or not? Anyway, there is an urgent need for something nicer then what I have done in here, cause what I have done is quite dumb :)

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@julczka julczka changed the title Feature/partial views workspace WORK IN PROGRESS Feature/partial views Jul 21, 2023
@julczka julczka marked this pull request as ready for review July 21, 2023 14:42
@iOvergaard iOvergaard merged commit 9986c33 into main Jul 24, 2023
@iOvergaard iOvergaard deleted the feature/partial-views-workspace branch July 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants