Skip to content

Improvement: Move modal files from shared to core #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2023
Merged

Improvement: Move modal files from shared to core #928

merged 5 commits into from
Oct 17, 2023

Conversation

madsrasmussen
Copy link
Contributor

This PR moves the modal files from the shared folder into the core package, so we don't have two modal modules.

@nielslyngsoe nielslyngsoe merged commit 5857d7c into main Oct 17, 2023
@nielslyngsoe nielslyngsoe deleted the improvement-clean-up-modal-from-shared branch October 17, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

@iOvergaard iOvergaard Awaiting requested review from iOvergaard

@JesmoDev JesmoDev Awaiting requested review from JesmoDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @nielslyngsoe