Skip to content

Feature/code editor modal fix #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2023
Merged

Feature/code editor modal fix #929

merged 5 commits into from
Oct 17, 2023

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Oct 16, 2023 •
edited
Loading

This PR focuses on Rich Text Editor.

  • Fixed the code editor modal. The modal is used with the Rich Text Editor (TinyMCE)
  • Fixed some issues with the Link Picker Plugin in Rich Text Editor.
    • Transferring queryString correctly between the picker and editor
    • Transferring the link title correctly between the picker and editor

Where are stylesheets going to be saved for Rich Text Editors?

@loivsen loivsen marked this pull request as draft October 16, 2023 09:06
@loivsen loivsen marked this pull request as ready for review October 16, 2023 12:14
@loivsen loivsen requested a review from iOvergaard October 16, 2023 12:14
@iOvergaard
Copy link
Collaborator

Looks good but there is a file conflict, @loivsen 😎

@iOvergaard iOvergaard merged commit aea79cd into main Oct 17, 2023
@iOvergaard iOvergaard deleted the feature/code-editor-modal-fix branch October 17, 2023 13:51
@nielslyngsoe
Copy link
Member

Good follow up, and now its merged :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loivsen @iOvergaard @nielslyngsoe