Fix missing toolbar icons shown in configuration of richtext editor

[bjarnef]

Description

Added missing icons shown at toolbar in configuration of richtext editor.

The tinymce doesn't contain a "default" property, but IconManager directly. Not sure why, but when when output to console in render function, it seems to log twice.

Before

After

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

• If my change requires a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.

[bjarnef]

@iOvergaard @loivsen seeems like an oversight?

[nielslyngsoe]

@bjarnef looks good to me, there is though a TypeScript issue. I assume TinyMCE is not TypeScript, if that's true then I recommend casting you import to any. otherwise, try to see what you can do to get the right type.

[bjarnef]

@nielslyngsoe ahh, I see the failed test.

I noticed elsewhere in code where it use type instead.

Umbraco.CMS.Backoffice/src/packages/core/components/input-tiny-mce/input-tiny-mce.handlers.ts

Line 1 in 62c3fc8

import type { tinymce } from '@umbraco-cms/backoffice/external/tinymce';

but then I get an error:

'tinymce' cannot be used as a value because it was imported using 'import type'.ts

[nielslyngsoe]

Cool, thanks!

[bjarnef]

@nielslyngsoe is there a reason elsewhere in code it use type?

Umbraco.CMS.Backoffice/src/packages/core/components/input-tiny-mce/tiny-mce-plugin.ts

Line 2 in 527936f

import type { tinymce } from '@umbraco-cms/backoffice/external/tinymce';

[nielslyngsoe]

@bjarnef when we apply type to the import statement it basically means that we do not want a real import, we just want to borrow the type in the TypeScript compile check. :-) So if the code is actually used, then we should not append type to the import statement :-)

[iOvergaard]

LGTM