Skip to content

Markdown keybindings and img tags #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 8, 2023
Merged

Markdown keybindings and img tags #943

merged 6 commits into from
Nov 8, 2023

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Oct 24, 2023

Description

Markdown editor

  • Adjustments to the keybindings. Changing the keybindings to resemble the Github Markdown keybindings.
  • Action buttons title tooltip now also contains the keybindings.
  • Fixed the sanitizeHtml to not remove IMG tags.
  • Styling of preview when inserting inline code, code block, & horizontal lines.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@loivsen loivsen changed the title init Markdown Keybindings & IMG tag Oct 24, 2023
@loivsen loivsen changed the title Markdown Keybindings & IMG tag Markdown keybindings and img tags Oct 24, 2023
iOvergaard
iOvergaard requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loivsen Looks good, but it needs to be updated for DOMPurify which we are using now, since sanitize-html didn't work as expected in the build :)

@loivsen loivsen enabled auto-merge November 8, 2023 11:32
@loivsen loivsen requested a review from iOvergaard November 8, 2023 12:45
iOvergaard
iOvergaard approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loivsen loivsen merged commit a5715be into main Nov 8, 2023
@loivsen loivsen deleted the feature/markdown-keybindings-and-img-url branch November 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loivsen @iOvergaard @nielslyngsoe