backward compatible icons and using lucide icons #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…and-backwards-compatible # Conflicts: # src/packages/core/property-editor/uis/tiny-mce/config/manifests.ts # src/packages/core/property-editor/uis/tiny-mce/manifests.ts
…://github.com/umbraco/Umbraco.CMS.Backoffice into feature/lucide-icons-and-backwards-compatible
…m Props, so we can theme them and change as time goes.
|
Now you are touching all the icons anyway, can you then move the |
…and-backwards-compatible
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-963.westeurope.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-963.westeurope.1.azurestaticapps.net |
2 similar comments
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-963.westeurope.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-963.westeurope.1.azurestaticapps.net |
iOvergaard
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make icon names backward compatible.
And appends new icons from Lucide, which replaces existing icons.
Add legacy option for icons, so they cannot be picked in the Icon Picker.
Requires two PRs of UI Library to be handled first and upgraded to a version of UUI where that takes part:
umbraco/Umbraco.UI#629
umbraco/Umbraco.UI#649
Description
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist